Use XID_START and XID_CONTINUE character classes #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-ubskii
changed the title
dmitrii-ubskii
force-pushed
the
wb-fix
branch
from
2992506 to
f713d8e
Compare
dmitrii-ubskii
commented
Dec 18, 2025
| | '\u{203F}'..'\u{2040}' | ||
| } | ||
| IDENTIFIER_START = @{ XID_START } | ||
| IDENTIFIER_CONTINUE = @{ "-" | XID_CONTINUE } |
Member
Author
There was a problem hiding this comment.
- is not in XID_CONTINUE, but a valid continuation character in TypeQL identifiers.
flyingsilverfin
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product change and motivation
We use
XID_STARTandXID_CONTINUEcharacter classes provided by pest instead of manually listing unicode codepoint ranges for our identifiers. We also change the definition of the word boundary (WB) to be "any character that is not an identifier continuation character" that resolves parsing bugs such aslet $var= 4;failing to parse:=is notPUNCTUATION, so not valid word boundary.Implementation