-
-
Notifications
You must be signed in to change notification settings - Fork 344
feat: Handle references for exception sets in Synchronized Groups #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle references for exception sets in Synchronized Groups #1014
Conversation
Generate permanent references for PBXFileSystemSynchronizedExceptionSet objects, including build file and build phase exception sets. Updates tests to verify that references for exception sets are correctly converted to permanent values.
|
@fortmarek @yonaskolb @pepicrft can someone please help with reviewing this? I would really appreciate it. |
yonaskolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @mirkokg!
|
I'm not familiar with the CI workflows in this repo anymore but looks like there are just some formatting errors related to trailing spaces. |
Remove empty space
Format code
|
@yonaskolb I removed extra spaces. Thanks! |
|
Thanks @mirkokg. We can merge it once CI is green. |
|
Thanks! |
Generate permanent references for PBXFileSystemSynchronizedExceptionSet objects, including build file and build phase exception sets. Updates tests to verify that references for exception sets are correctly converted to permanent values.
Resolves #934
Short description 📝
When creating projects with PBXFileSystemSynchronizedRootGroup objects that contain exception sets (PBXFileSystemSynchronizedBuildFileExceptionSet or PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet), the exception set IDs were being written with TEMP_ prefixes instead of proper deterministic IDs.
Solution 📦
Extended the ReferenceGenerator to process exception sets when generating references for synchronized root groups. Added a new generateExceptionSetReferences method that:
This follows the same pattern used for other object types in the reference generator.
Implementation 👩💻👨💻