-
Notifications
You must be signed in to change notification settings - Fork 136
Add 3d subcell limiting example with nonconservative terms #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add 3d subcell limiting example with nonconservative terms #2688
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
+ Coverage 96.84% 96.86% +0.02%
==========================================
Files 549 550 +1
Lines 43304 43539 +235
==========================================
+ Hits 41935 42170 +235
Misses 1369 1369
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Daniel Doehring <[email protected]>
DanielDoehring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from software-engineering viewpoint
Add 3d subcell limiting support for nonconservative terms of type
NonConservativeSymmetric.