add option to set precision level for humanized output#50
add option to set precision level for humanized output#50alfie-max wants to merge 1 commit intotmlee:masterfrom
Conversation
AlexWayfer
left a comment
AlexWayfer
left a comment
There was a problem hiding this comment.
It looks for a long time unmaintained. I personally have switched to maintained moments.
| gem.version = "0.7.0" | ||
| gem.license = 'MIT' | ||
|
|
||
| gem.add_runtime_dependency('activesupport', '~> 5.1') |
There was a problem hiding this comment.
yea.. but there was no need to hard code the activesupport version here, since this wont support rails 6 now.
There was a problem hiding this comment.
Maybe, but it's better to make unrelated changes in separate PRs.
There was a problem hiding this comment.
ok.. i'll create seaprate PR then
There was a problem hiding this comment.
Nice! I think that we can close this one in favor of these two.
There was a problem hiding this comment.
Or, honestly, you could change this one to something main, like precision, left it without unrelated changes, like activesupport version, and create only one separate for your case, with this activesupport version change.
2 participants
not sure if this repo is still maintained..
But found this changes helpful for a customized response