Skip to content

feat: Adding Keyboard Incognito#10975

Merged
rafaeltonholo merged 3 commits into
thunderbird:mainfrom
saisafe:keyboard-incognito
Jul 8, 2026
Merged

feat: Adding Keyboard Incognito#10975
rafaeltonholo merged 3 commits into
thunderbird:mainfrom
saisafe:keyboard-incognito

Conversation

@saisafe

@saisafe saisafe commented May 2, 2026

Copy link
Copy Markdown
Contributor

Closes #3855 (really old!)
label: exclude

The suggestion of the issue was to add settings toggle under privacy but looks better as a default privacy protection.

@rafaeltonholo rafaeltonholo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saisafe,

I apologize for the delay in reviewing these changes.

After discussing them with the team, we find these changes quite interesting and would like to have them added to the app. However, we believe that the decision to enable the keyboard in incognito mode should be left up to the user, rather than mandated by us.

To proceed with accepting this PR, you will need to introduce a user setting that allows users to enable or disable this feature at their discretion, with the default setting being off, as it is currently.

Please refer to our documentation to learn more about implementing User Settings. If you need any assistance with making these changes, feel free to reach out to me.

Thank you for your understanding!

@saisafe

saisafe commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Hi @rafaeltonholo

Thank you for the update.

To proceed with accepting this PR, you will need to introduce a user setting that allows users to enable or disable this feature at their discretion, with the default setting being off, as it is currently.

Noted, I'll add the user setting under general settings>privacy.

I need help with the title for the user setting and hope the description is "disables google keyboard from training user words."

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Validation Passed: All report and feature-flag labels are correctly set.

@rafaeltonholo rafaeltonholo added the report: include Include changes in user-facing reports. label Jul 7, 2026
- Added Settings option as toggle selection
- AI assisted title and description of setting option

@rafaeltonholo rafaeltonholo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments!

@rafaeltonholo rafaeltonholo added report: highlight Highlight changes (major feature, breaking, or noticeable to users) in user-facing reports. and removed report: include Include changes in user-facing reports. labels Jul 8, 2026
@rafaeltonholo rafaeltonholo merged commit 2be1527 into thunderbird:main Jul 8, 2026
19 checks passed
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 22 milestone Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: highlight Highlight changes (major feature, breaking, or noticeable to users) in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add keyboard incognito mode

2 participants