feat: Adding Keyboard Incognito#10975
Conversation
rafaeltonholo
left a comment
There was a problem hiding this comment.
Hi @saisafe,
I apologize for the delay in reviewing these changes.
After discussing them with the team, we find these changes quite interesting and would like to have them added to the app. However, we believe that the decision to enable the keyboard in incognito mode should be left up to the user, rather than mandated by us.
To proceed with accepting this PR, you will need to introduce a user setting that allows users to enable or disable this feature at their discretion, with the default setting being off, as it is currently.
Please refer to our documentation to learn more about implementing User Settings. If you need any assistance with making these changes, feel free to reach out to me.
Thank you for your understanding!
|
Thank you for the update.
Noted, I'll add the user setting under general settings>privacy. I need help with the title for the user setting and hope the description is "disables google keyboard from training user words." |
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
- Added Settings option as toggle selection - AI assisted title and description of setting option
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing the comments!
Closes #3855 (really old!)
label: exclude
The suggestion of the issue was to add settings toggle under privacy but looks better as a default privacy protection.