WIP: Fix intermittent integration test failures#231
Draft
rwood-moz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fix some mailstrom intermittent integration test failures.
Why?
The tests are mostly (98%) stable but would be nice to get rid of the intermittent failures.
Limitations and Notes
Changes made by Codex AI; we will see how these changes prove out after a couple weeks in CI. More details:
Changes made so far:
Fixed IMAP deletion test calls in test_messaging.py and test_messaging.py so single message ids are passed as lists to
imap.delete_messages(). This prevents multi-digit ids like"25"from being iterated character-by-character.Hardened
IMAP.delete_messages()in IMAP.py so it verifies\Deletedby fetching message flags afterSTORE, rather than depending on the exact shape of theSTOREresponse data.Improved
JMAP.wait_for_message_to_arrive()in JMAP.py to dynamically resolve the active account’s Inbox id, poll immediately, wait up to 7 minutes, accept one or more matching messages, and log the account/inbox being checked.Updated
JMAP.query_email()in JMAP.py to makecollapse_threadsconfigurable, preserving the existing default while allowing arrival polling to query withcollapse_threads=False. This should help self-send CC/BCC tests where collapsed thread results may hide the inbox copy.Applicable Issues
Fixes #230.
QA Log