ThirdwebBridge - Onramp Integration & Improved APIs#148
Merged
0xFirekeeper merged 2 commits intomainfrom May 9, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
- Coverage 62.19% 61.00% -1.19%
==========================================
Files 41 41
Lines 6427 6563 +136
Branches 822 832 +10
==========================================
+ Hits 3997 4004 +7
- Misses 2243 2373 +130
+ Partials 187 186 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TOOL-4441
PR-Codex overview
This PR focuses on enhancing the
ThirdwebBridgefunctionality by updating transaction handling to useStepsinstead ofTransactions, introducing new methods for onramp operations, and improving data structures for transaction steps and quotes.Detailed summary
Executemethods to useStepsinstead ofTransactions.OnrampPrepareDataandOnrampStatusDataclasses for onramp operations.Onramp_PrepareandOnramp_Status.TransactionandQuoteDataclasses to accommodate new structures.Transactionsin favor ofStepsin various data classes.BuyandSellmethods.