fix: auction payout can be locked before execute#636
Open
Leechael wants to merge 1 commit intothirdweb-dev:mainfrom
Open
fix: auction payout can be locked before execute#636Leechael wants to merge 1 commit intothirdweb-dev:mainfrom
Leechael wants to merge 1 commit intothirdweb-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
collectAuctionPayoutfunction, it becomes apparent that the variablepaidOutBidAmountis set totruebefore the necessaryrequirechecks are performed. This has the potential to cause an issue where the auction creator does not receive their tokens, even if the auction is successful and has expired.contracts/contracts/prebuilts/marketplace/english-auctions/EnglishAuctionsLogic.sol
Lines 147 to 166 in a9e6477
This PR aims to fix the potential issue.