use table for nexus registry #3064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraceGardner
requested review from
laurakwhit
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rossnelson
approved these changes
Dec 16, 2025
Collaborator
rossnelson
left a comment
rossnelson
left a comment
There was a problem hiding this comment.
Awesome! The move to runes is a great choice.
rossnelson
reviewed
Dec 16, 2025
rossnelson
approved these changes
Dec 18, 2025
Collaborator
|
We should keep our tables consistent in Nexus with all our other tables 
|
Contributor
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| const payloads = await encodePayloads({ | ||
| input: JSON.stringify(body.spec.descriptionString), | ||
| encoding: 'json/plain', | ||
| }); |
Contributor
There was a problem hiding this comment.
⚠️ Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'IPayloads'.
Alex-Tideman
approved these changes
Jan 5, 2026
| const payloads = await encodePayloads({ | ||
| input: JSON.stringify(body.spec.descriptionString), | ||
| encoding: 'json/plain', | ||
| }); |
Contributor
There was a problem hiding this comment.
⚠️ Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'IPayloads'.
| delete body.spec.descriptionString; | ||
| } | ||
| try { |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
| } | ||
| try { | ||
| await updateNexusEndpoint(endpoint.id, body); |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
| error = undefined; | ||
| loading = true; | ||
| try { |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?