[Worker-Versioning-GA]: Reject versioning-override when the version exists. #8742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
Dec 3, 2025
| // WorkerDeploymentVersionIdDelimiterV31 will be deleted once we stop supporting v31 version string fields | ||
| // in external and internal APIs. Until then, both delimiters are banned in deployment name. All | ||
| // deprecated version string fields in APIs keep using the old delimiter. Workflow SA uses new delimiter. | ||
| WorkerDeploymentVersionIdDelimiterV31 = "." |
Member
Author
There was a problem hiding this comment.
please review this PR when this one gets in: #8706
Member
Author
|
closing this one since its duplicated here: #8791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks