sync: import latest source/taos-community subtree (3.3.6)

[feici02]

Sync source/taos-community/ subtree from the internal 3.3.6 monorepo branch.

• Source: rd-public/tsdb branch 3.3.6 (HEAD: 4958eece10f)
• Prefix: source/taos-community
• Target: taosdata/tdengine branch 3.3.6
• Traversal: --first-parent (each commit is the integration point of an MR; trees stay correct across parallel merges)

Generated by tools/sync/subtree-split-fast.sh with author/committer identities preserved on every commit.

[gemini-code-assist]

Code Review

This pull request introduces several key enhancements and bug fixes, including a new KILL COMPACT FORCE command to forcefully terminate compaction tasks, a backup mechanism for corrupted WAL files, Linux Release binary size optimizations, and a fix for tag name/value misalignment in TMQ metadata. It also enhances the vnode repair tool with secure temp file handling and adds comprehensive test coverage. The code review identified three important issues: a potential infinite loop or double-processing bug in hashset_remove due to in-place rehashing, a risk of path truncation in WAL file backups due to small buffer sizes, and ignored exit statuses for SSH commands in the repair tool.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

In hashset_remove, rehashing subsequent entries in-place can lead to infinite loops or double-processing of the same item. If an item val from slot j is re-inserted at a slot k that is further down the probe chain (which was previously empty but is now filled by val), the loop will eventually reach k and process val again. To prevent this, all subsequent occupied slots in the cluster should be collected first, cleared from the hashset, and then re-inserted.

      // Collect subsequent entries in the same cluster to avoid infinite loops/double-processing
      size_t capacity = set->capacity;
      size_t *to_reinsert = tdbOsCalloc(capacity, sizeof(size_t));
      if (to_reinsert == NULL) {
        return 1;
      }
      int count = 0;
      for (size_t j = set->mask & (h + prime2); set->items[j] != 0; j = set->mask & (j + prime2)) {
        to_reinsert[count++] = set->items[j];
        set->items[j] = 0;
        --set->nitems;
      }
      for (int i = 0; i < count; i++) {
        int nt = hashset_add_member(set, (void *)to_reinsert[i]);
      }
      tdbOsFree(to_reinsert);

[gemini-code-assist]

Using WAL_FILE_LEN + TSDB_FILENAME_LEN for srcFile and dstFile buffers can lead to path truncation if the source or destination directory path is long (since tsWalCorruptionBackupDir can be up to PATH_MAX). It is safer to use PATH_MAX for both buffers to prevent buffer truncation and copy failures.

    char srcFile[PATH_MAX];
    char dstFile[PATH_MAX];

[gemini-code-assist]

The exit status of the popen command is ignored. If the SSH command fails (e.g., connection timeout, authentication failure, or host offline), pclose(fp) will return a non-zero status, but the function currently proceeds as long as some data was read or the file is non-empty. Checking status != 0 ensures that any SSH command failure is correctly detected and handled. Additionally, fread returns size_t, so nRead should be declared as size_t to avoid signed/unsigned comparison warnings.

  FILE *fp = popen(cmd, "r");
  if (fp == NULL) {
    uError("repair: failed to run ssh command");
    (void)close(fd);
    (void)taosRemoveFile(localPathBuf);
    return -1;
  }

  char   buf[4096];
  size_t nRead;
  while ((nRead = fread(buf, 1, sizeof(buf), fp)) > 0) {
    ssize_t nWritten = 0;
    while (nWritten < (ssize_t)nRead) {
      ssize_t w = write(fd, buf + nWritten, (ssize_t)nRead - nWritten);
      if (w < 0) {
        uError("repair: write to temp file failed: %s", strerror(errno));
        (void)pclose(fp);
        (void)close(fd);
        (void)taosRemoveFile(localPathBuf);
        return -1;
      }
      nWritten += w;
    }
  }

  int status = pclose(fp);
  (void)close(fd);

  if (status != 0) {
    uError("repair: ssh command failed");
    (void)taosRemoveFile(localPathBuf);
    return -1;
  }