Skip to content

build: release ver-3.4.1.6#35240

Draft
tomchon wants to merge 1 commit into
mainfrom
release/ver-3.4.1.6
Draft

build: release ver-3.4.1.6#35240
tomchon wants to merge 1 commit into
mainfrom
release/ver-3.4.1.6

Conversation

@tomchon

@tomchon tomchon commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 3.4.1.6 and hardcodes this version tag for the taosadapter external project. The review feedback recommends using the TD_VER_NUMBER variable instead of hardcoded strings in the CMake configuration to improve maintainability and ensure consistency.

Comment thread tools/CMakeLists.txt
Comment thread tools/CMakeLists.txt
@tomchon tomchon closed this Apr 30, 2026
@tomchon tomchon reopened this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants