feature #301 [FORM] Modify make:form to allow non-entities (ckrack)

This PR was squashed before being merged into the 1.0-dev branch (closes #301).

Discussion
----------

[FORM] Modify make:form to allow non-entities

Before this modification the make:form command allowed passing a fully specified classname.
It would generate a form with the correct bound class,  but not read the fields.
It generated a form with one "field_name" field instead of something more useful.
This also affects DTOs.
This modification makes our lives easier by reading all fields of the bound class, except the id field.

Commits
-------

b753768 [FORM] Modify make:form to allow non-entities

Author: weaverryan

src/Maker/MakeForm.php

@@ -18,6 +18,7 @@
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
 use Symfony\Bundle\MakerBundle\Str;
+use Symfony\Bundle\MakerBundle\Util\ClassDetails;
 use Symfony\Bundle\MakerBundle\Validator;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
@@ -95,6 +96,9 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
 
             if (null !== $doctrineEntityDetails) {
                 $formFields = $doctrineEntityDetails->getFormFields();
+            } else {
+                $classDetails = new ClassDetails($boundClassDetails->getFullName());
+                $formFields = $classDetails->getFormFields();
             }
 
             $boundClassVars = [

src/Util/ClassDetails.php

@@ -0,0 +1,51 @@
+<?php
+
+/*
+ * This file is part of the Symfony MakerBundle package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\MakerBundle\Util;
+
+/**
+ * @internal
+ */
+final class ClassDetails
+{
+    private $fullClassName;
+
+    public function __construct(string $fullClassName)
+    {
+        $this->fullClassName = $fullClassName;
+    }
+
+    /**
+     * Get list of property names except "id" for use in a make:form context.
+     *
+     * @return array|null
+     */
+    public function getFormFields(): array
+    {
+        $properties = $this->getProperties();
+
+        return array_diff($properties, ['id']);
+    }
+
+    private function getProperties(): array
+    {
+        $reflect = new \ReflectionClass($this->fullClassName);
+        $props = $reflect->getProperties();
+
+        $propertiesList = [];
+
+        foreach ($props as $prop) {
+            $propertiesList[] = $prop->getName();
+        }
+
+        return $propertiesList;
+    }
+}

tests/Maker/FunctionalTest.php

@@ -188,6 +188,16 @@ public function getCommandTests()
             ])
             ->addExtraDependencies('orm')
             ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeFormForEntity')
+		];
+
+        yield 'form_for_non_entity_dto' => [MakerTestDetails::createTest(
+            $this->getMakerInstance(MakeForm::class),
+            [
+                // Entity name
+                'TaskType',
+                '\\App\\Form\\Data\\TaskData',
+            ])
+            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeFormForNonEntityDto')
         ];
 
         yield 'form_for_sti_entity' => [MakerTestDetails::createTest(

tests/fixtures/MakeFormForNonEntityDto/src/Form/Data/TaskData.php

@@ -0,0 +1,22 @@
+<?php
+
+/*
+ * This file is part of the Symfony MakerBundle package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Form\Data;
+
+/**
+ * Data transfer object for Task.
+ */
+class TaskData
+{
+    public $task;
+
+    public $dueDate;
+}

tests/fixtures/MakeFormForNonEntityDto/tests/GeneratedFormTest.php

@@ -0,0 +1,49 @@
+<?php
+
+/*
+ * This file is part of the Symfony MakerBundle package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace App\Tests;
+
+use App\Form\Data\TaskData;
+use App\Form\TaskType;
+use Symfony\Component\Form\Test\TypeTestCase;
+
+class GeneratedFormTest extends TypeTestCase
+{
+    public function testGeneratedForm()
+    {
+        $dateTimeObject = new \DateTime();
+
+        $formData = [
+            'task' => 'Acme',
+            'dueDate' => $dateTimeObject,
+        ];
+
+        $objectToCompare = new TaskData();
+
+        $form = $this->factory->create(TaskType::class, $objectToCompare);
+        $form->submit($formData);
+
+        $object = new TaskData();
+        $object->task = 'Acme';
+        $object->dueDate = $dateTimeObject;
+
+        $this->assertTrue($form->isSynchronized());
+        $this->assertEquals($object, $objectToCompare);
+        $this->assertEquals($object, $form->getData());
+
+        $view = $form->createView();
+        $children = $view->children;
+
+        foreach (array_keys($formData) as $key) {
+            $this->assertArrayHasKey($key, $children);
+        }
+    }
+}