minor #300 [CRUD] Redirect to index after edit (ckrack)

weaverryan · weaverryan · commit bff115328478 · 2018-11-02T15:50:17.000-04:00
This PR was squashed before being merged into the 1.0-dev branch (closes #300). Discussion ---------- [CRUD] Redirect to index after edit Update the generated edit action. This now redirects to the index instead of the edit form. Fixes #257 Commits ------- ab697d1 Fix tests e5c9d1d Redirect to index after edit
diff --git a/src/Resources/skeleton/crud/controller/Controller.tpl.php b/src/Resources/skeleton/crud/controller/Controller.tpl.php
@@ -78,7 +78,7 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va
         if ($form->isSubmitted() && $form->isValid()) {
             $this->getDoctrine()->getManager()->flush();
 
-            return $this->redirectToRoute('<?= $route_name ?>_edit', ['<?= $entity_identifier ?>' => $<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>()]);
+            return $this->redirectToRoute('<?= $route_name ?>_index', ['<?= $entity_identifier ?>' => $<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>()]);
         }
 
         return $this->render('<?= $templates_path ?>/edit.html.twig', [
diff --git a/tests/fixtures/MakeCrud/tests/GeneratedCrudControllerTest.php b/tests/fixtures/MakeCrud/tests/GeneratedCrudControllerTest.php
@@ -44,15 +44,6 @@ public function testIndexAction()
         $crawler = $client->followRedirect();
         $this->assertTrue($client->getResponse()->isSuccessful());
         $this->assertContains('<!DOCTYPE html>', $client->getResponse()->getContent());
-        $this->assertContains('Edit SweetFood', $client->getResponse()->getContent());
-        $this->assertGreaterThan(0, $crawler->filter('input[type=text]')->count());
-        $this->assertEquals('Candy edited', $crawler->filter('input[type=text]')->attr('value'));
-
-        $backTolistLink = $crawler->filter('a:contains("back to list")')->eq(0)->link();
-
-        $crawler = $client->click($backTolistLink);
-        $this->assertTrue($client->getResponse()->isSuccessful());
-        $this->assertContains('<!DOCTYPE html>', $client->getResponse()->getContent());
         $this->assertContains('SweetFood index', $client->getResponse()->getContent());
         $this->assertContains('Candy edited', $client->getResponse()->getContent());
 
diff --git a/tests/fixtures/MakeCrudInCustomRootNamespace/tests/GeneratedCrudControllerTest.php b/tests/fixtures/MakeCrudInCustomRootNamespace/tests/GeneratedCrudControllerTest.php
@@ -44,15 +44,6 @@ public function testIndexAction()
         $crawler = $client->followRedirect();
         $this->assertTrue($client->getResponse()->isSuccessful());
         $this->assertContains('<!DOCTYPE html>', $client->getResponse()->getContent());
-        $this->assertContains('Edit SweetFood', $client->getResponse()->getContent());
-        $this->assertGreaterThan(0, $crawler->filter('input[type=text]')->count());
-        $this->assertEquals('Candy edited', $crawler->filter('input[type=text]')->attr('value'));
-
-        $backTolistLink = $crawler->filter('a:contains("back to list")')->eq(0)->link();
-
-        $crawler = $client->click($backTolistLink);
-        $this->assertTrue($client->getResponse()->isSuccessful());
-        $this->assertContains('<!DOCTYPE html>', $client->getResponse()->getContent());
         $this->assertContains('SweetFood index', $client->getResponse()->getContent());
         $this->assertContains('Candy edited', $client->getResponse()->getContent());
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public function edit(Request $request, <?= $entity_class_name ?> $<?= $entity_va`
`78`	`78`	`if ($form->isSubmitted() && $form->isValid()) {`
`79`	`79`	`$this->getDoctrine()->getManager()->flush();`
`80`	`80`
`81`		`- return $this->redirectToRoute('<?= $route_name ?>_edit', ['<?= $entity_identifier ?>' => $<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>()]);`
	`81`	`+ return $this->redirectToRoute('<?= $route_name ?>_index', ['<?= $entity_identifier ?>' => $<?= $entity_var_singular ?>->get<?= ucfirst($entity_identifier) ?>()]);`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`return $this->render('<?= $templates_path ?>/edit.html.twig', [`