ALARADFrame Half-Life Filtering #217
Conversation
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Perhaps we should discuss as a group (incl. via slack) whether we need any half-life operators that include equality. Since this is float data, it is always dubious to use any real equality comparison anyway.
| half_lives = set(self.loc[ | ||
| self['half_life'].apply(lambda x: isinstance(x, float)), | ||
| 'half_life' | ||
| ]) |
There was a problem hiding this comment.
While this isn't too complicated, it makes we wonder if it isn't better to use some special float to indicate stable nuclides, e.g. -1? Then this could just be a simpler filter for half_life >= 0?
| '>=' : operator.ge, | ||
| '<=' : operator.le, | ||
| '==' : operator.eq, | ||
| '!=' : operator.ne |
There was a problem hiding this comment.
Given the precision of floating point operations I wonder if we need any of these that include equality? Limiting it to just < and > might make it all a little simpler, too.
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
LGTM - thanks @eitan-weinstein
2 participants
Closes #216.
Closes #203.
Closes #202 .
This PR follows the inclusion of half-lives into the canonical structure of ALARADFrames in #206. I've introduced filtering capabilities in
alara_output_processing.filter_rows()for users to filter on the stability or lack thereof of the nuclides in the ALARADFrame, as well as filtering half-lives against time thresholds (i.e. preserving all nuclides with a half-live greater than 1e6 seconds).