fix: cheaper hostname/SAN check#1194
Open
ferhatelmas wants to merge 2 commits into
Open
Conversation
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes Postgres TLS connection setup for IP-based hosts (e.g., PgBouncer) by bypassing Node’s default hostname/SAN identity checking to avoid unnecessary work when the hostname is an IP address.
Changes:
- Add a no-op
checkServerIdentitycallback for IP-host connections ingetSslSettings. - Extend unit tests to assert
checkServerIdentitybehavior for IP hosts and absence for named hosts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/internal/database/ssl.ts | Adds a no-op checkServerIdentity in the IP-host SSL settings path. |
| src/internal/database/ssl.test.ts | Updates tests to assert presence/behavior of checkServerIdentity for IP hosts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+44
| return { | ||
| secureContext, | ||
| rejectUnauthorized: false, | ||
| checkServerIdentity: dontCheckServerIdentity, | ||
| } |
Coverage Report for CI Build 28618583063Coverage increased (+0.001%) to 78.822%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Node gets certificate and delivers it to the default identity checker, which always fails with IPs. This default does identity matching and error construction (allocation), then discards it.
What is the new behavior?
Replace identity checker with noop.
Additional context
Certificate extraction price will still be paid (will check session resumption separately).