Added BOTH streaming service ID as a special case for the Twitch #1604
+40
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
summeroff
approved these changes
Dec 4, 2025
sandboxcoder
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added BOTH streaming service ID as a special case for the Twitch Dual Output
Motivation and Context
This change fixes the following case:
When we enable Enhanced Broadcasting we send our data to Twitch and get encoders configuration.
With the Twitch Dual Streaming I started to send info about all created canvases. We can have 2 at max for now.
So Twitch thinks that we are going to start dual streaming and makes it easy on encoders because it thinks that we are going to send 2 streams. That is the reason why we see not so many resolution options. But why do we have 2 canvases in a single streaming mode? You know the answer. Due to historical reasons. So to fix this I need to know somehow that stream is going to use enhanced broadcasting, but it is a single streaming mode, not dual output.
How Has This Been Tested?
By QA. Windows.
Types of changes