generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 574
feat(models): preserve token ids for OpenAI-compatible streaming #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dk67604
wants to merge
1
commit into
strands-agents:main
Choose a base branch
from
dk67604:feat/token-ids-vllm-openai
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,611
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
vLLM Test Output: |
Add SGLang native /generate provider with token-in/out and SSE streaming. Refactor vLLM provider for token-in/out, tool-use streaming, and preserve provider fields. Update event loop streaming to carry additionalModelResponseFields.
9b53a86 to
f0ef731
Compare
Author
|
SGLang Test Output |
|
@pgrayy What do you think on integrating this for RL training, I am happy to coordinate on this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables token-in/token-out workflows for agentic RL by preserving provider-specific token ID data end-to-end when using OpenAI-compatible servers (validated with vLLM).
Changes:
invocation_state["model_kwargs"]is now passed through the event loop intoModel.stream(). This allows passing OpenAI-compatible extensions likeextra_body={"return_token_ids": True}per request.messageStop.additionalModelResponseFieldsis now carried into the finalAgentResult.messageso downstream RL code can read token IDs without retokenization.OpenAIModel.stream()now collectsprompt_token_idsand streamedtoken_ids(vLLM) and emits them viaadditionalModelResponseFields.Related Issues
Fixes #1368
Documentation PR
N/A
Type of Change
New feature
Testing
hatch test tests/strands/models/test_openai.py tests/strands/event_loop/test_streaming.pySTRANDS_RUN_VLLM_INTEG=1 pytest -q -k vllm_token_idshatch run prepareChecklist