Respect user-provided CFLAGS #836
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure.ac unconditionally overwrote CFLAGS, ignoring user-provided flags. Running `CFLAGS="-O3 -march=native" ./configure` had no effect. Fix by using LIBMODBUS_CFLAGS via AM_CFLAGS in Makefile.am, following standard autoconf/automake conventions. User CFLAGS are now appended last and can override project defaults. Behavior: - ./configure : -O2 (unchanged) - ./configure --enable-debug : -g -O0 (unchanged) - CFLAGS="-O3" ./configure : -O3 (now respected) - CFLAGS="-O3" ./configure --enable-debug : -O3 (user priority) Also removes unused CXXFLAGS handling (pure C library).
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure.ac unconditionally overwrote CFLAGS, ignoring user-provided flags. Running
CFLAGS="-O3 -march=native" ./configurehad no effect.Fix by using LIBMODBUS_CFLAGS via AM_CFLAGS in Makefile.am, following standard autoconf/automake conventions. User CFLAGS are now appended last and can override project defaults.
Behavior:
Also removes unused CXXFLAGS handling (pure C library).
Closes #830.
This will also allow proper coverage tracking on oss-fuzz (https://introspector.oss-fuzz.com/project-profile?project=libmodbus). Currently, coverage is only collected for the harness code. This change should enable coverage tracking for all code.