Skip to content

disable clang assembler #7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
siddarthkay wants to merge 3 commits into
base: unstable
Choose a base branch
from
Draft

disable clang assembler #7765

siddarthkay wants to merge 3 commits into from

Conversation

@siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Nov 29, 2025 •
edited
Loading

@siddarthkay siddarthkay self-assigned this Nov 29, 2025
tersec
tersec reviewed Nov 29, 2025
View reviewed changes
@siddarthkay siddarthkay marked this pull request as draft November 29, 2025 03:11
@siddarthkay siddarthkay force-pushed the disable-clang-assembler branch from d95ff7f to e8dca48 Compare November 29, 2025 03:15
@github-actions
Copy link

github-actions bot commented Nov 29, 2025 •
edited
Loading

Unit Test Results

       12 files  ±0    2 432 suites  ±0   44m 28s ⏱️ + 1m 22s
12 670 tests ±0  12 105 ✔️ ±0  565 💤 ±0  0 ❌ ±0 
63 684 runs  ±0  62 956 ✔️ ±0  728 💤 ±0  0 ❌ ±0 

Results for commit 921c930. ± Comparison against base commit 48e7508.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Nov 29, 2025

Now it does https://ci.status.im/job/nimbus-eth2/job/platforms/job/macos/job/aarch64/job/main/job/PR-7765/4/display/redirect

[2025-11-29T03:34:17.746Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-4c69ea.s:7:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:17.746Z]         .file   5 "generated_not_to_break_here"
[2025-11-29T03:34:17.746Z]         ^
[2025-11-29T03:34:18.201Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-546aca.s:3:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.202Z]         .file   1 "generated_not_to_break_here"
[2025-11-29T03:34:18.202Z]         ^
[2025-11-29T03:34:18.202Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-7e3728.s:6:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.202Z]         .file   4 "vendor/nimbus-build-system/vendor/Nim/lib/std/private" "digitsutils.nim"
[2025-11-29T03:34:18.202Z]         ^
[2025-11-29T03:34:18.202Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-432187.s:3:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.202Z]         .file   1 "vendor/nimbus-build-system/vendor/Nim/lib/std" "assertions.nim"
[2025-11-29T03:34:18.202Z]         ^
[2025-11-29T03:34:18.202Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-1097a4.s:6:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.202Z]         .file   4 "vendor/nimbus-build-system/vendor/Nim/lib/std/private" "dragonbox.nim"
[2025-11-29T03:34:18.202Z]         ^
[2025-11-29T03:34:18.657Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-7e7967.s:3:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.657Z]         .file   1 "vendor/nimbus-build-system/vendor/Nim/lib/std" "formatfloat.nim"
[2025-11-29T03:34:18.658Z]         ^
[2025-11-29T03:34:18.658Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-8bc827.s:3:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:18.658Z]         .file   1 "vendor/nimbus-build-system/vendor/Nim/lib/std/private" "miscdollars.nim"
[2025-11-29T03:34:18.658Z]         ^
[2025-11-29T03:34:19.113Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-2b72eb.s:3:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:19.113Z]         .file   1 "vendor/nimbus-build-system/vendor/Nim/lib/system" "dollars.nim"
[2025-11-29T03:34:19.113Z]         ^
[2025-11-29T03:34:19.113Z] /var/folders/f1/1zphnv895rx1x1mjp11s5j4r0006vn/T/@m-7f8c5a.s:12:2: warning: inconsistent use of MD5 checksums
[2025-11-29T03:34:19.113Z]         .file   4 "vendor/nimbus-build-system/vendor/Nim/lib/system" "threadids.nim"

@siddarthkay siddarthkay force-pushed the disable-clang-assembler branch 2 times, most recently from 4c10d46 to 1fa230b Compare November 30, 2025 04:30
@siddarthkay siddarthkay force-pushed the disable-clang-assembler branch from 75c78dd to 921c930 Compare November 30, 2025 11:13
@siddarthkay siddarthkay marked this pull request as ready for review November 30, 2025 11:14
tersec
tersec reviewed Dec 2, 2025
View reviewed changes
ci/Jenkinsfile.macos
pipeline {
/* This way we run the same Jenkinsfile on different platforms. */
agent { label 'macos && aarch64' }
agent { label 'macm1-01' }
Copy link
Contributor

@tersec tersec Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is meant to be merged yet but if so, probably should be in the PR? Or if it's still trying to debug macm1-01 specifically, sure.

tersec
tersec reviewed Dec 2, 2025
View reviewed changes
.gitmodules
url = https://github.com/status-im/nim-ssz-serialization.git
ignore = untracked
branch = master
branch = hashtree-which-skips-clang-assembler
Copy link
Contributor

@tersec tersec Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that inclined either to merge something which uses a non-trunk branch, either.

So I assume this PR is still in progress.

Copy link
Member

@jakubgs jakubgs Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be in draft.

@siddarthkay siddarthkay marked this pull request as draft December 3, 2025 16:17
@siddarthkay siddarthkay mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubgs jakubgs jakubgs approved these changes

@tersec tersec tersec left review comments

Assignees

@siddarthkay siddarthkay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddarthkay @tersec @jakubgs