Disable taskpools at compile time when threads are not enabled #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhartnett
commented
Dec 17, 2025
| taskpools, | ||
| utils | ||
|
|
||
| when compileOption("threads"): |
Contributor
Author
There was a problem hiding this comment.
@tersec Thoughts on using this switch? Is this the recommended way to check if threads are enabled at compile time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we disable the taskpools code in the EL at compile time when
--threads:offis set.We want to be able to compile the stateless execution function on bare metal for the zkEVM integration but the task pools code doesn't compile on bare metal and is not needed in that context either so we should support disabling it.