Conversation
This reverts commit 88f319d.
Member
Author
adwk67
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
adwk67
reviewed
Jan 23, 2026
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
LGTM code-wise, tests pass, and the code comments are really thorough! However, I couldn't get the example to work. Maybe we need to include this as an extra test so that we regularly verify it?
adwk67
previously approved these changes
Jan 23, 2026
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
LGTM - the example works fine now. Thanks!
Nit: just a couple of places to clarify the steps should be run from one of the broker pods.
Co-authored-by: Andrew Kenworthy <[email protected]>
adwk67
approved these changes
Jan 23, 2026
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
Member
|
Could you add release notes here or in the parent issue? Or am I missing them somewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes stackabletech/issues#811
Requires decision: https://github.com/stackabletech/decisions/issues/70
🟢 CI https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/kafka-operator-it-custom/80/