-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(tui): add header/footer/shortcuts toggle and improve prompt info line #5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
19ba1c0 to
68e8b49
Compare
|
@emamulandalib What about deciding based on size of screen? With commands, we ask the user to do the job of not showing things as soon as the size of the screen is too small. On a big screen, I'm fine with all this extra info (and I might want it!) |
68e8b49 to
5b4d125
Compare
|
@lcswillems I've added commands to toggle the header, footer, and shortcuts (though I'm unsure what the best term for 'shortcuts' is). I was also considering automatic hiding of these elements, but that would require further community discussion. Here are some screenshots
|
5b4d125 to
ab8fa56
Compare
c6cdb6a to
805b634
Compare
|
@emamulandalib It is great that you've worked on this! However, in my case, I don't really want to have to do the job of hiding / showing stuff each time I resize the window. The issue is stating that things should be hidden when the screen is small, so this PR doesn't really address the issue? |
@lcswillems, I am seeking community feedback regarding which UI elements should be hidden on smaller screens. Currently, only the sidebar logic is implemented to respond to screen size changes. opencode/packages/opencode/src/cli/cmd/tui/routes/session/index.tsx Lines 127 to 132 in feb8c4f
Should we also consider automatic hiding for small screens? For example:
I think we should hide header/footer for the smaller screen. |
1e9fdb9 to
772368f
Compare
|
Personally I'd say that anything non-mandatory to be displayed in order to continue chatting should be hidden when the screen is too small. |
|
Thank you for the feedback. I was working on the implementation, but I encountered several questions. Maybe you can help me here. Current Thresholds (Independent Checks)
Would we prefer:
Behavior Matrix
|
7cba854 to
d334708
Compare
…zation Add System commands to toggle header, footer, and shortcuts visibility via command palette (ctrl+p). All preferences persist across restarts. - All toggle commands under System category in app.tsx - Available globally (home + session pages) - When footer hidden: compact status shown in prompt info line - When footer visible: detailed status in bottom section Fixes sst#5277
d334708 to
91930d5
Compare
|
@emamulandalib I don't know (haven't checked the columns and so on). From your tests, what do you think would be the best numbers? |




Summary
Add System commands to toggle header, footer, and shortcuts visibility for small screen optimization. All preferences persist across restarts.
Commands Added (System category)
All commands available globally (home + session pages) via command palette (ctrl+p).
Behavior
When Footer Hidden
When Footer Visible
Fixes #5277