Skip to content

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 4, 2026

I guess it was not implemented because it should never happen (the error would be detected at the stat() stage)

My beef is more about the fact that createDirectory() return true if there is an error 🤔
which is counter-intuitive ; I would expect return false in case of an error... 🫠


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 4, 2026
@bakpaul
Copy link
Contributor

bakpaul commented Feb 4, 2026

Linked to this : #5924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants