Skip to content

Conversation

@alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Feb 2, 2026

This is to fix the warnings enabled by W4 (#5913) on Sofa.Type

3>RGBAColor.cpp(65,12): Warning C4244 : 'initializing': conversion from 'int' to 'char', possible loss of data
3>RGBAColor.cpp(171,15): Warning C4244 : 'initializing': conversion from 'int' to 'char', possible loss of data
3>RGBAColor.cpp(175,22): Warning C4244 : '=': conversion from 'int' to 'char', possible loss of data
3>RGBAColor.cpp(216,30): Warning C4244 : 'initializing': conversion from 'int' to 'char', possible loss of data
3>RGBAColor.cpp(216,22): Warning C4244 : 'initializing': conversion from 'int' to 'const char', possible loss of data

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 2, 2026
@alxbilger alxbilger changed the title Fixrgbacolor [Type] Fix type conversion in RGBAColor Feb 2, 2026
@fredroy
Copy link
Contributor

fredroy commented Feb 2, 2026

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants