CMake & Nix: add tight_inclusion#5916
CMake & Nix: add tight_inclusion#5916nim65s wants to merge 1 commit intosofa-framework:hugtalbot-patch-2from
Conversation
|
Hello ! Yes there is a fork of us with patches fixing packaging (this has been made for Conda) The patch list is here : https://github.com/conda-forge/tight-inclusion-feedstock/tree/main/recipe/patches We plan to make PR on the original fork. |
|
The introduced CMake find module for tight inclusion will be used instead of the CMake config file, such as the one provided by the conda package in our Pixi build chain. |
|
I'll workaround that by using directly your conda patches in nix, but clearly the good solution is to contribute the cmake exports upstream |
095e274 to
f59d252
Compare
This is a quick and dirty workaround, proper packaging should really be contributed upstream.
f59d252 to
8590bf6
Compare
|
Thanks for the update. Yes, we usually fix upstream for all patches we have to make for conda packages and here we've plan to do it as well asap. We'll let you know once done. |
This is a quick and dirty temporary workaround, following discussions with @hugtalbot,
but proper packaging should really be contributed upstream.
Do you have plans for this @olivier-roussel @bakpaul ?
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if