Skip to content

CMake & Nix: add tight_inclusion#5916

Open
nim65s wants to merge 1 commit intosofa-framework:hugtalbot-patch-2from
nim65s:hugtalbot-patch-2
Open

CMake & Nix: add tight_inclusion#5916
nim65s wants to merge 1 commit intosofa-framework:hugtalbot-patch-2from
nim65s:hugtalbot-patch-2

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Feb 2, 2026

This is a quick and dirty temporary workaround, following discussions with @hugtalbot,
but proper packaging should really be contributed upstream.

Do you have plans for this @olivier-roussel @bakpaul ?


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request topic for next dev-meeting PR to be discussed in sofa-dev meeting labels Feb 2, 2026
@bakpaul
Copy link
Contributor

bakpaul commented Feb 3, 2026

Hello ! Yes there is a fork of us with patches fixing packaging (this has been made for Conda)

The patch list is here : https://github.com/conda-forge/tight-inclusion-feedstock/tree/main/recipe/patches

We plan to make PR on the original fork.

@olivier-roussel
Copy link
Contributor

olivier-roussel commented Feb 3, 2026

The introduced CMake find module for tight inclusion will be used instead of the CMake config file, such as the one provided by the conda package in our Pixi build chain.
We should either find a way to give priority to CMake Config file (which I thought to be the case in modern CMake, but I tested and it was not), either this CMake module file should be adapted to follow our general needs, such as defining targets and install properties (see https://github.com/sofa-framework/sofa/blob/master/cmake/Modules/FindTinyXML2.cmake for example). They should also support DLL properly for installation on Windows in our releases (https://github.com/olivier-roussel/sofa/blob/a8547ce0cb53576927efe84379b4829dd27d2a75/cmake/Modules/FindTinyXML2.cmake), but it's out of the scope of this PR and it will be handled in #5252 (for tracking).

@nim65s
Copy link
Contributor Author

nim65s commented Feb 3, 2026

I'll workaround that by using directly your conda patches in nix, but clearly the good solution is to contribute the cmake exports upstream

@nim65s nim65s force-pushed the hugtalbot-patch-2 branch 3 times, most recently from 095e274 to f59d252 Compare February 3, 2026 16:27
This is a quick and dirty workaround,
proper packaging should really be contributed upstream.
@nim65s nim65s force-pushed the hugtalbot-patch-2 branch from f59d252 to 8590bf6 Compare February 3, 2026 16:28
@olivier-roussel
Copy link
Contributor

Thanks for the update. Yes, we usually fix upstream for all patches we have to make for conda packages and here we've plan to do it as well asap. We'll let you know once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request topic for next dev-meeting PR to be discussed in sofa-dev meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants