[All] Security: unsafe string operations #5902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
fredroy
force-pushed
the
fix_vulnerabilities_string
branch
from
0c9de53 to
8d9a23b
Compare
bakpaul
requested changes
Jan 30, 2026
Contributor
bakpaul
left a comment
bakpaul
left a comment
There was a problem hiding this comment.
I think you are going to hate me...
applications/plugins/SofaImplicitField/components/geometry/DiscreteGridField.cpp
Show resolved
Hide resolved
applications/plugins/SofaImplicitField/components/geometry/DiscreteGridField.cpp
Show resolved
Hide resolved
...ion/Response/Contact/src/sofa/component/collision/response/contact/RuleBasedContactManager.h
Show resolved
Hide resolved
...ion/Response/Contact/src/sofa/component/collision/response/contact/RuleBasedContactManager.h
Show resolved
Hide resolved
Sofa/Component/Engine/Transform/src/sofa/component/engine/transform/TransformPosition.inl
Outdated
Show resolved
Hide resolved
Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/CompressedRowSparseMatrixGeneric.h
Outdated
Show resolved
Hide resolved
Contributor
Author
yes 😾 |
fredroy
force-pushed
the
fix_vulnerabilities_string
branch
3 times, most recently
from
ac9f49c to
77923a7
Compare
bakpaul
approved these changes
Feb 3, 2026
Contributor
bakpaul
left a comment
bakpaul
left a comment
There was a problem hiding this comment.
Still one unit test failing,; except this, this PR seems fine by me
…handle invalid input and overflow conditions in string-to-number conversions
…t prevent buffer overflows
fredroy
force-pushed
the
fix_vulnerabilities_string
branch
from
77923a7 to
0114992
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unhandled exception from different string calls and replace unsafe calls of string functions
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if