[All] Security: fix overflows #5901
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
fredroy
force-pushed
the
fix_vulnerabilities_overflows
branch
from
cbcd999 to
e942da9
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
requested changes
Jan 30, 2026
...Collision/Response/Mapper/src/sofa/component/collision/response/mapper/BaseContactMapper.cpp
Show resolved
Hide resolved
...tion/src/sofa/component/constraint/lagrangian/correction/PrecomputedConstraintCorrection.inl
Show resolved
Hide resolved
Sofa/Component/Engine/Transform/src/sofa/component/engine/transform/TransformPosition.inl
Show resolved
Hide resolved
Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/BlockFullMatrix.inl
Outdated
Show resolved
Hide resolved
Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/BTDMatrix.inl
Outdated
Show resolved
Hide resolved
fredroy
force-pushed
the
fix_vulnerabilities_overflows
branch
from
e942da9 to
6c9a8b2
Compare
…reading and writing same buffer). Fixed: sscanf(buf, "%*127s %127s", matName); Breaking down the format: - %*127s - The * is the assignment suppression modifier. It means "read up to 127 chars but discard them (don't store)". This skips the first word (like "newmtl") - %127s - Read the second word (the material name), limited to 127 chars, store in matName So if buf contains "newmtl MyMaterial\n": - %*127s reads and discards "newmtl" - %127s reads "MyMaterial" into matName The 127 limit prevents buffer overflow since matName is 128 bytes (127 chars + null terminator).
… buffer overflows from size calculation wraparound
fredroy
force-pushed
the
fix_vulnerabilities_overflows
branch
from
6c9a8b2 to
d79f4e4
Compare
bakpaul
reviewed
Feb 4, 2026
Comment on lines
+865
to
871
| if (lines.empty()) | ||
| { | ||
| m.resize(0, 0); | ||
| if( in.rdstate() & std::ios_base::eofbit ) { in.clear(); } | ||
| } | ||
|
|
||
| m.resize( (Index)lines.size(), (Index)lines[0].size() ); |
Contributor
There was a problem hiding this comment.
I am sorry but I wasn't clear enough. What I really wanted was to keep the compress. It is sufficient to wrap the resize in a if/else statement.
Suggested change
| if (lines.empty()) | |
| { | |
| m.resize(0, 0); | |
| if( in.rdstate() & std::ios_base::eofbit ) { in.clear(); } | |
| } | |
| m.resize( (Index)lines.size(), (Index)lines[0].size() ); | |
| if (lines.empty()) | |
| { | |
| m.resize(0, 0); | |
| } | |
| else | |
| { | |
| m.resize( (Index)lines.size(), (Index)lines[0].size() ); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different overflows risk were not checked,
and one array access is a bug (in BaseContactMapper)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if