[Collision] Introduce multi-staged collision pipeline#5841
Open
fredroy wants to merge 28 commits intosofa-framework:masterfrom
Open
[Collision] Introduce multi-staged collision pipeline#5841fredroy wants to merge 28 commits intosofa-framework:masterfrom
fredroy wants to merge 28 commits intosofa-framework:masterfrom
Conversation
9d2bf0b to
bbabba1
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bbabba1 to
fed32d2
Compare
bakpaul
requested changes
Jan 6, 2026
...n/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/CollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...ection/Algorithm/src/sofa/component/collision/detection/algorithm/MultiCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/CompositeCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...ection/Algorithm/src/sofa/component/collision/detection/algorithm/MultiCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/MultiCollisionPipeline.h
Outdated
Show resolved
Hide resolved
alxbilger
reviewed
Jan 14, 2026
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...n/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/CollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...n/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/CollisionPipeline.cpp
Show resolved
Hide resolved
...ection/Algorithm/src/sofa/component/collision/detection/algorithm/MultiCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
9518785 to
add0b08
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
hugtalbot
reviewed
Jan 23, 2026
...on/Algorithm/src/sofa/component/collision/detection/algorithm/AbstractSubCollisionPipeline.h
Outdated
Show resolved
Hide resolved
...on/Algorithm/src/sofa/component/collision/detection/algorithm/CompositeCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
ef2ed2f to
893613b
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #15. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #16. To unlock the merge button, you must
|
hugtalbot
approved these changes
Jan 27, 2026
Collaborator
|
[ci-depends-on] detected during build #17. To unlock the merge button, you must
|
e1b30ab to
4f048ad
Compare
Collaborator
|
[ci-depends-on] detected during build #18. To unlock the merge button, you must
|
…t/collision/detection/algorithm/MultiCollisionPipeline.h Co-authored-by: Paul Baksic <[email protected]>
…t/collision/detection/algorithm/CollisionPipeline.cpp - add assertion Co-authored-by: Alex Bilger <[email protected]>
Co-authored-by: Hugo <[email protected]>
4f048ad to
3ac2add
Compare
Collaborator
|
[ci-depends-on] detected during build #19. To unlock the merge button, you must
|
alxbilger
reviewed
Feb 4, 2026
...n/Detection/Algorithm/src/sofa/component/collision/detection/algorithm/CollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
...etection/Algorithm/src/sofa/component/collision/detection/algorithm/SubCollisionPipeline.cpp
Outdated
Show resolved
Hide resolved
bakpaul
approved these changes
Feb 4, 2026
…t/collision/detection/algorithm/CollisionPipeline.cpp (update msg) Co-authored-by: Alex Bilger <[email protected]>
Collaborator
|
[ci-depends-on] detected during build #20. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #21. To unlock the merge button, you must
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
Add the ability to have multiple collision pipeline in a scene, instead of one monolithic pipeline (presented at the STC20)
This allows a lot of things:
It adds a warning if no collision model are handled by any pipeline.
This PR also adds a not-an-alias for
CollisionPipelinesimilar toBruteForceDetection, but in this case I would not deprecate it and would be more seen as a convenience for most users, as the whole Multi + Sub collision pipeline is quite verbose in the end. And the former CollisionPipeline was doing a lot of things implicitly.EDIT: with this, PipelineImpl is not used anymore (and has ... a dubious implementation by the way)
[with-all-tests]
[ci-depends-on https://github.com/sofa-framework/Regression/pull/96]
EDIT2: examples for a showcase

w/o Composite Pipeline[same collision distance, the 2nd sphere cannot go through]w/ Composite Pipeline[different collision distances, the 2nd case has a smaller one so the sphere can go through]By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if