Skip to content

DNM: Trap demo on cap call #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nolag wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DNM: Trap demo on cap call #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/workflows/wasm/host/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,45 +1223,45 @@ func createCallCapFn(
func createAwaitCapsFn(
logger logger.Logger,
exec *execution[*sdkpb.ExecutionResult],
) func(caller *wasmtime.Caller, awaitRequest, awaitRequestLen, responseBuffer, maxResponseLen int32) int64 {
return func(caller *wasmtime.Caller, awaitRequest, awaitRequestLen, responseBuffer, maxResponseLen int32) int64 {
) func(caller *wasmtime.Caller, awaitRequest, awaitRequestLen, responseBuffer, maxResponseLen int32) (int64, *wasmtime.Trap) {
return func(caller *wasmtime.Caller, awaitRequest, awaitRequestLen, responseBuffer, maxResponseLen int32) (int64, *wasmtime.Trap) {
b, err := wasmRead(caller, awaitRequest, awaitRequestLen)
if err != nil {
errStr := fmt.Sprintf("error reading from wasm %s", err)
logger.Error(errStr)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen), nil
}

req := &sdkpb.AwaitCapabilitiesRequest{}
err = proto.Unmarshal(b, req)
if err != nil {
errStr := err.Error()
logger.Error(errStr)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen), nil
}

resp, err := exec.awaitCapabilities(exec.ctx, req)
if err != nil {
errStr := err.Error()
logger.Error(errStr)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen), nil
}

respBytes, err := proto.Marshal(resp)
if err != nil {
errStr := err.Error()
logger.Error(errStr)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen), nil
}

size := wasmWrite(caller, respBytes, responseBuffer, maxResponseLen)
if size == -1 {
errStr := ResponseBufferTooSmall
logger.Error(errStr)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen)
return truncateWasmWrite(caller, []byte(errStr), responseBuffer, maxResponseLen), nil
}

return size
return size, wasmtime.NewTrap("Nope don't run")
}
}

Expand Down
Loading