feat: improve UnionMax, UnionMin, ReverseSign, Negative, ToNumber and add ToBigint, SplitFloat and SeperateNegatives internal types
#1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes, improve and rename `StringToNumber` to `ToNumber` and add `ToBigint`, `SplitFloat` and `SeperateNegatives` internal types
benzaria
changed the title
UnionMax, UnionMin, ReverseSign and Negative types, improve and rename StringToNumber to ToNumber and add ToBigint, SplitFloat and SeperateNegatives internal typesUnionMax, UnionMin, ReverseSign, Negative, ToNumber and add ToBigint, SplitFloat and SeperateNegatives internal types
sindresorhus
requested changes
Oct 22, 2025
Co-authored-by: Sindre Sorhus <[email protected]>
improve `SplitFloat`, Update documentation to reflect support for negative numbers in UnionMin and UnionMax types.
Co-authored-by: Sindre Sorhus <[email protected]>
Collaborator
|
@benzaria Are all of these changes related and need to be part of the same PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
UnionMaxandUnionMin.SeperateNegativesinternal type to split a number union to[positives, negatives].bigintsupport forReverseSign.Negativetype returningneverforNegativeInfinity.StringToNumber -> ToNumberto includebigintandbooleansimilare toNumber(T).ToBigintinternal type to transforme supported types tobigint.SplitFloatinternal type to use as a simpleRoundtype at the moment.