-
Notifications
You must be signed in to change notification settings - Fork 26
Test HSDS API #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test HSDS API #1926
Conversation
| /cypress/snapshots/**/__diff_output__ | ||
| /cypress/snapshots/**/__received_output__ | ||
|
|
||
| /support/hsds/root/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root is the name of the default bucket,a s configured in support/hsds/config/override.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use a more explicit name e.g. test-bucket
| "support:sample": "poetry -C support/sample run python create_h5_sample.py", | ||
| "support:h5grove": "poetry -C support/h5grove run python tornado_app.py --basedir ../sample/dist", | ||
| "support:hsds": "rm -rf support/hsds/hs.log && poetry -C support/hsds run hsds --root_dir . --config_dir ./config --password_file ./config/passwd.txt", | ||
| "support:hsds:load": "rm -rf support/hsds/root/* && poetry -C support/hsds run hsload -e http://localhost:5101 -u test -p test --link ../sample/dist/sample-hsds.h5 /", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
testadmin user's password is defined inconfig/passwd.txt - The file is loaded into the root folder of the bucket
/andhsloadautomatically creates a new "domain" for the file called/sample-hsds.h5 - From what I understand,
--linkmeans that the data stays in the file
| private readonly baseURL: string, | ||
| filepath: string, | ||
| private readonly fetcher: Fetcher, | ||
| private readonly fetcher = createBasicFetcher(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've managed to configure the HSDS support server to allow unauthenticated requests, so I'm making the fetcher parameter optional so I don't have to pass it in hsds-api.ts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the snapshot file. I've already identified a few issues/inconsistencies with other providers, like a few "Unknown" dtypes, which I'll try to fix.
t20100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| /cypress/snapshots/**/__diff_output__ | ||
| /cypress/snapshots/**/__received_output__ | ||
|
|
||
| /support/hsds/root/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use a more explicit name e.g. test-bucket
support/hsdswith hsds and h5pydsupport/hsds/config)--hsdsflag tocreate_h5_sample.pyto createsample-hsds.h5without datasets not supported byhsloadsupport:hsdsandsupport:hsds:loadscripts to respectively start the HSDS support server and loadsample-hsds.h5into HSDShsds-api.test.tsfile and run test to create Vitest snapshot fileOpening as draft as I'm having issues in the CI: the HSDS support server won't fully start for some reason. Also, I'm installing and testing the latest version of
hsds(andh5pyd), but the demo server on Bosquet still runs an older version.