LT-18927: Normalize incoming SFM Data to NFD #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SFM import duplicating list items with diacritics by normalizing SFM to NFD before looking up internal data since the internal list data is NFD. Change-Id: If9342ab2244203915a156a945264e1b56764a869
Change-Id: I104c0cc02735a3e114aed2839725cfbb91e15705
mark-sil
approved these changes
Jan 20, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aror92).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where the SFM import duplicates list items with diacritics by normalizing SFM to NFD before looking up internal data, since the internal list data is NFD.
This change is