General fix to Lexicon Edit Popup problems #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
BTW, Bharanidharan's error was the result of refreshing the interlinear text after senses were merged and the interlinear text having a reference to the sense that was deleted by the merge. |
jtmaxwell3
changed the title
jasonleenaylor
approved these changes
Jan 13, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3).
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
I'm approving this for now (to stave off the crashes) but I would rather see the menu items disabled.
@jasonleenaylor made 1 comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general fix to problems with the Lexicon Edit Popup window, of which https://jira.sil.org/browse/LT-22352 is one instance (see in particular Bharanidharan's comment). The general problem is that the Lexicon Edit Popup window often violates the assumptions in the context menu commands and cause them to crash. In particular, there is an assumption that the Lexicon Edit pane is in the Lexicon frame and there are no other edit windows active at the same time. There are too many context menu commands in the Lexicon Edit pane to try to fix them all. So I disabled all of them. If the user tries to use a context menu, they get the error "Context menus are disabled in popup windows.".
This change is