fix(agent): type _multilingual as Optional so the None initializer checks#44
Open
jakubkarolczyk wants to merge 1 commit into
Open
fix(agent): type _multilingual as Optional so the None initializer checks#44jakubkarolczyk wants to merge 1 commit into
jakubkarolczyk wants to merge 1 commit into
Conversation
…ecks set_multilingual() assigns _multilingual a dict[str, Any], so mypy inferred that as its type and rejected 'self._multilingual = None' in AgentBase.__init__ (agent_base.py:289) — the TYPECHECK gate is red on main. Declare _multilingual explicitly as dict[str, Any] | None on AIConfigMixin (which owns set_multilingual), so both the None default and the dict assignment type-check. Type-only; no behavior change. Whole-repo mypy: 0 findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_multilingual()assigns_multilingualadict[str, Any], so mypy infers that as its type and rejectsself._multilingual = NoneinAgentBase.__init__(agent_base.py:289) — the TYPECHECK gate is currently red onmainbecause of it.Fix: declare
_multilingual: dict[str, Any] | None = Noneexplicitly onAIConfigMixin(the class that ownsset_multilingual), so both theNonedefault and the dict assignment type-check.