Record math backend and thread-pool metadata#242
Record math backend and thread-pool metadata#242google-labs-jules[bot] wants to merge 4 commits into
Conversation
|
🤖 The observability direction is useful, but this implementation needs work. |
|
I have addressed all the feedback points. Specifically:
|
…-observability-js0-3e8f2201-fb05-4d2a-978d-acc92b885f29
|
🤖 claude review this current head 0b5a7ba. This is a review-only readiness request; no branch modification is requested. Focus on the separation of NumPy build dependencies from loaded thread-pool libraries, Apple Accelerate visibility, non-fatal collection errors, manifest placement and warning-list immutability, human/JSON CLI contracts, capability/schema registration, factual documentation, and tests. Local verification after merging current develop: 58 tests passed; pre-commit, Ruff, formatting, ty, and Sphinx passed. Please list any Blocking or Important findings and explicitly state whether this head is safe to mark ready. |
|
I have reviewed the current head (0b5a7ba) against the criteria requested. Here are the findings:
Conclusion: |
|
🤖 Looks good. Current head 0b5a7ba cleanly separates NumPy build metadata from loaded thread-pool state, reports Apple Accelerate and collection failures factually, keeps manifest inputs immutable, and exposes the same contract through CLI discovery and docs. The full required CI matrix is green and the readiness review found no Blocking or Important issues. Marked ready for review. |
|
Thank you for the review and confirmation! All previous feedback has been successfully addressed, and as indicated by the readiness review, there are no outstanding issues or requested changes. The PR is ready for merge. |
Summary
Design notes
NumPy build metadata and loaded thread-pool libraries are separate facts. This matters on Apple platforms: Accelerate can be the NumPy BLAS/LAPACK dependency while threadpoolctl reports no BLAS library. The metadata is observational only and does not claim a numerical tolerance or flag multiple libraries as inherently conflicting.
Verification