Skip to content

Conversation

@estellesoulard
Copy link
Contributor

For terraform plugin framework schema attributes:

  • add custom soft validation with warning for locality (zone or region)
  • add strong UUID validation
  • add localized UUID validation

@estellesoulard estellesoulard requested review from a team and remyleone as code owners December 12, 2025 11:23
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Dec 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 44.82759% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.76%. Comparing base (3a9607b) to head (d5242fc).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/locality/zonal/schemas_framework.go 0.00% 7 Missing ⚠️
internal/verify/framework.go 81.25% 5 Missing and 1 partial ⚠️
internal/locality/regional/schemas_framework.go 0.00% 5 Missing ⚠️
...rvices/cockpit/action_trigger_test_alert_action.go 0.00% 4 Missing ⚠️
internal/services/instance/action_server_action.go 0.00% 4 Missing ⚠️
...al/services/keymanager/action_rotate_key_action.go 0.00% 4 Missing ⚠️
...ervices/jobs/action_start_job_definition_action.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3532      +/-   ##
=========================================
+ Coverage    1.71%   1.76%   +0.05%     
=========================================
  Files         420     422       +2     
  Lines       45910   45952      +42     
=========================================
+ Hits          787     813      +26     
- Misses      45036   45051      +15     
- Partials       87      88       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@estellesoulard estellesoulard force-pushed the chore/add-custom-framework-validators branch from d1a4138 to 93f7b53 Compare December 12, 2025 17:23
@estellesoulard estellesoulard force-pushed the chore/add-custom-framework-validators branch from 93f7b53 to d5242fc Compare December 12, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants