feat(mongodb): add mongodb instance snapshot action #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3494 +/- ##
=========================================
- Coverage 1.71% 1.70% -0.01%
=========================================
Files 420 421 +1
Lines 45909 46035 +126
=========================================
Hits 787 787
- Misses 45035 45161 +126
Partials 87 87 ☔ View full report in Codecov by Sentry. |
jremy42
force-pushed
the
feat/mongodb-instance-snapshot-action
branch
17 times, most recently
from
263c8dd to
8432199
Compare
remyleone
reviewed
Dec 4, 2025
remyleone
reviewed
Dec 11, 2025
| Required: true, | ||
| Description: "MongoDB instance ID to snapshot. Can be a plain UUID or a regional ID.", | ||
| Validators: []validator.String{ | ||
| stringvalidator.LengthAtLeast(1), |
Member
There was a problem hiding this comment.
I don't think this validator is very helpful. It should be either removed or replaced with a proper validator that can check for a localized/unlocalized id
|
|
||
| snapshotName := data.Name.ValueString() | ||
| if snapshotName == "" { | ||
| snapshotName = "tf-mongodb-snapshot" |
Member
There was a problem hiding this comment.
could you add action also here to have more context in this default value?
jremy42
force-pushed
the
feat/mongodb-instance-snapshot-action
branch
from
da5f24c to
6075b7d
Compare
…it trail verification
jremy42
force-pushed
the
feat/mongodb-instance-snapshot-action
branch
from
10a205b to
6c9bf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3337