feat(ui): implement cursor-based pagination for messages #98
+449
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabrycina
commented
Dec 17, 2025
gabrycina
commented
- Add useInfiniteTaskMessages hook with cursor pagination
- Implement infinite scroll with IntersectionObserver in task-messages.tsx
- Add scroll position preservation when loading older messages
- Update SDK to 0.1.0-alpha.11 with listPaginated support
- Add spinner component for loading indicator
- Add useInfiniteTaskMessages hook with cursor pagination - Implement infinite scroll with IntersectionObserver in task-messages.tsx - Add scroll position preservation when loading older messages - Update SDK to 0.1.0-alpha.11 with listPaginated support - Add spinner component for loading indicator
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
There was a problem hiding this comment.
I'm noticing a bug where when I scroll to the top of the page and trigger a refetch, it scrolls back to the bottom of the page. I suspect this callback is being triggered somewhere
Screen.Recording.2025-12-17.at.9.35.10.AM.mov
Comment on lines
+314
to
+316
| <div className="flex justify-center py-4"> | ||
| <Spinner className="text-muted-foreground h-5 w-5" /> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
We already have an implementation of a loading spinner for infinite scrolling in the task-sidebar — lets choose one or the other to keep it consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.