perf: optimize /agents endpoint DI overhead #107
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add @lru_cache to repository and service factories for singleton behavior - Initialize AgentsUseCase on app.state during startup to bypass DI - Pre-compute authorized resources in auth middleware instead of per-route - Update list_agents route to use cached services from request/app state Performance improvement: ~93% throughput increase (304 → 587 req/s) Latency reduction: ~45% (33ms → 18ms avg)
- Clear cached repository factories before each test - Clear cached temporal adapter and agents use case - Initialize app.state in test fixture for list_agents route - Use is_enabled() method call for testability in middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@lru_cacheto repository and service factories for singleton behaviorAgentsUseCaseonapp.stateduring startup to bypass FastAPI DIlist_agentsroute to use cached services fromrequest.stateandapp.statePerformance Results
Profiling Breakdown
FastAPI DI overhead reduced from 31% to 2.5% of request time.
Test Plan
make test-unit)