Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport to the 3.17 branch, focusing on enhancing the stability and reliability of Object Storage adapter integration tests. The changes primarily address issues related to cloud storage specific behaviors, such as rate limiting and special character handling, ensuring the tests run more consistently and accurately reflect real-world cloud storage interactions.

Highlights

  • Rate Limit Mitigation: Introduced sleep delays in setUp, tearDown, and populateRecords methods within various Object Storage integration tests when running against cloud storage. This is to mitigate potential rate limit errors during test execution.
  • Cloud Storage Character Handling: Implemented a workaround for cloud storage environments where the 0xFF character might not be handled correctly. For text columns, the getColumnWithMaxValue method now returns a string filled with 'Z' characters instead of 0xFF when ObjectStorageEnv.isCloudStorage() is true.
  • Test Base Class Extensibility: Modified the access modifiers of recoveryExecutor, groupCommitter, setUp, and truncateTables in ConsensusCommitSpecificIntegrationTestBase from private to protected to allow subclasses to override or access these components.
  • Redundant Method Removal: Removed an unnecessary override of the getThreadNum() method in ObjectStorageConditionalMutationIntegrationTest.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/object-storage-adapter-check.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on adapting integration tests for Object Storage. Key changes include introducing strategic delays in setUp, tearDown, and populateRecords methods across several test classes to mitigate potential rate limit errors when interacting with cloud storage. Additionally, access modifiers for recoveryExecutor, groupCommitter, setUp, and truncateTables in ConsensusCommitSpecificIntegrationTestBase have been adjusted to protected, enabling subclasses to extend or override this functionality. A notable fix addresses a limitation in cloud storage by replacing the 0xFF character with 'Z' for DataType.TEXT in getColumnWithMaxValue overrides, ensuring compatibility and correctness. These changes are practical and necessary for robust integration testing with object storage backends.

@brfrn169 brfrn169 merged commit 87f712a into 3.17 Dec 3, 2025
207 of 209 checks passed
@brfrn169 brfrn169 deleted the 3.17-pull-3232 branch December 3, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants