Backport to branch(3) : Fix the integration test and workflow for Object Storage adapter

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix the integration test and workflow for Object Storage adapter #3232
• Backported commit: 7d4b2b9

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a backport aimed at stabilizing and improving the integration tests for the Object Storage adapter, specifically for branch(3). The changes primarily address common challenges encountered when running tests against cloud storage, such as mitigating rate limiting issues and ensuring proper handling of specific character sets. These adjustments help ensure the reliability and correctness of the Object Storage adapter's functionality in a cloud environment.

Highlights

• Rate Limit Mitigation for Cloud Storage Tests: Introduced Uninterruptibles.sleepUninterruptibly calls in the setUp, tearDown, and populateRecords methods of several Object Storage integration tests. These sleeps (1 or 2 seconds) are conditionally applied when running against cloud storage environments to mitigate potential rate limit errors during test execution.
• Improved Handling of Max Text Values in Cloud Storage: Modified the getColumnWithMaxValue method in various Object Storage scan integration tests. For text columns in cloud storage, it now uses a string of 'Z' characters as the maximum value instead of the 0xFF character, which is not correctly handled by some cloud storage systems.
• Adjusted Test Base Class Accessibility: Changed the access modifiers of recoveryExecutor, groupCommitter, setUp, and truncateTables in ConsensusCommitSpecificIntegrationTestBase from private to protected. This allows subclasses to more easily access or override these components and methods, enhancing test flexibility.
• Removed Redundant Thread Number Override: The explicit override for getThreadNum() in ObjectStorageConditionalMutationIntegrationTest was removed, allowing the test to inherit the default thread count behavior from its base class.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/object-storage-adapter-check.yaml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports changes to fix integration tests and workflows for the Object Storage adapter. The main changes involve adding delays to mitigate cloud storage rate limits and adjusting how max text values are handled for cloud storage, which doesn't correctly process 0xFF characters. Additionally, some fields and methods in the ConsensusCommitSpecificIntegrationTestBase were changed from private to protected to allow for proper extension in subclasses.