Add integration test for virtual tables with imported tables having various primary key types

[brfrn169]

Description

Virtual tables are created by joining two source tables. When using an imported table (an existing table created outside ScalarDB) as the left source table, we need to verify that the primary key types work correctly as join keys.

This PR adds an integration test to verify that virtual tables can be created and operated using imported tables as the left source table with various primary key types.

Related issues and/or PRs

N/A

Changes made

• Add a new integration test createVirtualTable_WithImportedTableHavingVariousPrimaryKeyTypes_ShouldWorkProperly to verify that virtual tables can be created using imported tables with various primary key types as the left source table, and that data can be put and scanned correctly
• Add getSupportedDataTypeMapForPrimaryKey() method to JdbcAdminImportTestUtils to provide data types that can be used as primary keys (and join keys) for each JDBC database engine (MySQL, PostgreSQL, Oracle, SQL Server, DB2)

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new integration test to ensure the robust functionality of virtual tables, specifically when they are formed by joining an imported table (an existing table outside ScalarDB) as the left source. The test validates that virtual tables can be correctly created and operated with a wide range of primary key data types across different JDBC database systems, thereby enhancing the reliability of virtual table operations with diverse data models.

Highlights

• New Integration Test: An integration test createVirtualTable_WithImportedTableHavingVariousPrimaryKeyTypes_ShouldWorkProperly has been added to verify virtual table creation and operation when the left source table is an imported table with diverse primary key types.
• Data Type Support: A new method getSupportedDataTypeMapForPrimaryKey() was introduced in JdbcAdminImportTestUtils to provide a mapping of supported primary key data types for various JDBC database engines (MySQL, PostgreSQL, Oracle, SQL Server, DB2).
• Test Base Class Modification: The admin, storage, and namespace fields in DistributedStorageVirtualTablesIntegrationTestBase were changed from private to protected to allow access from subclasses for extended testing scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a valuable integration test for virtual tables that use an imported table with various primary key types. The changes are well-structured, and the new test covers a good range of data types for different database engines.

My main feedback is to enhance the new integration test to also cover the LEFT_OUTER join scenario, as currently, the left outer join virtual table is created but not used in any data operations. I've also pointed out a minor cleanup for an unused logger.

Overall, this is a great addition to the test suite.

[Copilot]

Pull request overview

This PR adds comprehensive integration testing for virtual tables that use imported tables with various primary key data types as the left source table. Virtual tables in ScalarDB are created by joining two source tables, and this test ensures that when the left source table is an imported table (created outside ScalarDB), all supported primary key types work correctly as join keys.

Key Changes

• Modified base test class to expose admin, storage, and namespace fields to subclasses for more flexible testing
• Added a new integration test that validates virtual table creation and operations with imported tables having different primary key types across all supported JDBC databases
• Enhanced test utilities to provide database-specific mappings of SQL data types to ScalarDB data types for primary keys

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
integration-test/src/main/java/com/scalar/db/api/DistributedStorageVirtualTablesIntegrationTestBase.java	Changed visibility of admin, storage, and namespace fields from private to protected to enable subclass access
core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcSchemaLoaderImportIntegrationTest.java	Improved consistency by using fully qualified class name in @DisabledIf annotation and removed redundant helper method
core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcDatabaseVirtualTablesIntegrationTest.java	Added comprehensive test for virtual tables with imported tables having various primary key types, iterating through all supported data types for each database engine
core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminImportTestUtils.java	Added getSupportedDataTypeMapForPrimaryKey() method providing database-specific mappings of SQL primary key types to ScalarDB DataTypes for MySQL, PostgreSQL, Oracle, SQL Server, and DB2

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Torch3333]

LGTM, thank you!
I just added a suggestion, PTAL.

[feeblefakie]

LGTM! Thank you!

[komamitsu]

LGTM! 👍