build: Move notebook dependency to 'notebook' extra #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As sbi does not have any use of the notebook library itself it should not be a required dependency. Remove it from 'dependencies' and create a 'notebook' extra instead.
Contributor
Author
|
Given involvement and reviews of PRs #1217 and #1337 tagging @janfb, @michaeldeistler, and @dgedon for review. Let me know if you have any questions. 👍 |
janfb
approved these changes
Jan 5, 2026
Contributor
janfb
left a comment
janfb
left a comment
There was a problem hiding this comment.
Thank you @matthewfeickert for fixing this, I agree that a separate group makes sense here; and sorry for the delay - we were all in winter break it seems.
Contributor
Author
|
Thanks @janfb!
No worries! I was as well. :) Happy New Year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1713