Wasm: stabilize target_feature = "gc"#150183
Draft
daxpedda wants to merge 1 commit intorust-lang:mainfrom
Draft
Conversation
Member
|
To confirm about wasm-bindgen's use case, the intention here is that users will specify |
Contributor
Author
|
Yes! As I mentioned, this isn't a dealbreaker because we can just add a global flag. |
Member
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #150111, stabilizing the new target features.
While merging this has to wait until LLVM 22 releases, which is a long way off, I thought it might still be sensible to get FCP approval now. But let me know if this would be considered too premature.
Addresses #150260.
Companion PR: rust-lang/reference#2114.
r? @alexcrichton