glibc: Update symbol versions for tc{get,set}attr
#4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
stable-nominated
Contributor
|
@usamoi I haven't taken a super close look here yet but it appears fine, any reason this is marked as a draft? |
Contributor
Author
|
Contributor
Author
|
It's ready for review now. |
tgross35
changed the title
tc{get,set}attr
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup of #4882.
Thanks to @de-vri-es for the reminder, I noticed that due to changes in the
termiosstructure, mips(64) and sparc(64) gained new versions of thetcgetattrandtcsetattrsymbols in GLIBC 2.42. This PR also binds versions for thetcgetattrandtcsetattrsymbols on mips(64) and sparc(64). This PR fixes tests on mips(64) and sparc(64).In addition, I noticed that Rust also supports several tier-3 targets with
target_archset tomips32r6andmips64r6. This PR applies the previous fix to these two architectures as well.Sources
https://github.com/bminor/glibc
Checklist
@rustbot label +stable-nominated