Skip to content

Improve scan of regexp handling #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tompng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve scan of regexp handling #1572

tompng wants to merge 1 commit into from
+21 −22

Conversation

@tompng
Copy link
Member

@tompng tompng commented Jan 19, 2026

Scanning regexp handling that I implemented in #1559 was not performant.

  1. Run string.scan for each regexp handling once
  2. Collect matched locations
  3. Scan collected location from the beginning

@tompng tompng requested a deployment to fork-preview-protection January 19, 2026 19:24 — with GitHub Actions Waiting
@tompng tompng force-pushed the regexp_handling_scan branch from 057b0bb to 604a9d6 Compare January 19, 2026 19:43
@tompng tompng temporarily deployed to fork-preview-protection January 19, 2026 19:43 — with GitHub Actions Inactive
@matzbot
Copy link
Collaborator

matzbot commented Jan 19, 2026

🚀 Preview deployment available at: https://768a8d71.rdoc-6cd.pages.dev (commit: 604a9d6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @matzbot