Supports Ruby 3.0, Oauth2 2.0 , JWT 2.9.3#35
Supports Ruby 3.0, Oauth2 2.0 , JWT 2.9.3#35regismesquita wants to merge 9 commits intorootstrap:masterfrom
Conversation
|
Still working on updating JWT to ~> 2.9.3 |
|
Need to test some stuff internally but seems to be working as expected now. |
|
Hi, @blacksam07 and @TimoPeraza, tagging you here as the most recent committers in case the CODEOWNERS file isn’t current. Appreciate any input you can provide! |
blacksam07
left a comment
blacksam07
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contributions
| module AppleAuth | ||
| module Base | ||
| VERSION = '1.1.0' | ||
| # Updated major version as the gem is now compatible with Ruby 3.0 and OAuth2 2.0 |
There was a problem hiding this comment.
We can remove this comment and include it in the release notes
| # Apple seems to expect the auth_scheme to be on | ||
| # the body, the default is :basic_auth |
There was a problem hiding this comment.
We can remove this comments and include an explain in the readme file that now we already add the auth_schema in the body
Hi @regismesquita Thanks for you contribution is a great job, we will check the removal of support for older versions of Ruby and how we can continue with these changes. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.