[tmva][sofie] Add GELU activation operator #20788
Open
+121
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shlok-Saxena
changed the title
Author
|
For additional context, this PR is motivated by a recent ROOT forum discussion on TMVA SOFIE operator coverage, where GELU was identified as a missing activation that could be added: link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the GELU activation function in TMVA::Experimental::SOFIE.
The implementation follows the ONNX-specified tanh-based approximation of GELU and
integrates with the existing SOFIE operator and ONNX parser infrastructure.
Changes include:
The implementation mirrors the existing Relu operator pattern and was validated by
building ROOT with TMVA and SOFIE enabled.