[hist] Remove CINT compatibility constructors from TF1, THF2, and TF3 #20702
+2
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 19h 13m 44s ⏱️ Results for commit 462ce97. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Dec 11, 2025
guitargeek
force-pushed
the
tf_backward_compatibility
branch
from
3e94437 to
462ce97
Compare
lmoneta
approved these changes
Jan 6, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM, but please update the doc in
https://root.cern.ch/doc/master/classTF1.html#F6
The `TF1`, `TF2`, and `TF3` constructors for CINT compatibility can be removed. This concerns the templated constructors that additionally took the name of the used functor class and member function. With ROOT 6, these names can be omitted. See also commit 4e4cdfb from 2015, where these constructors were introduced. The idea is to clear a bit more the jungle of `TH1` constructors, of which there are too many. That makes it confusing for our uses and for cppyy overload resolution.
guitargeek
force-pushed
the
tf_backward_compatibility
branch
from
462ce97 to
5a5ab93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TF1,TF2, andTF3constructors for CINT compatibility can be removed. This concerns the templated constructors that additionally took the name of the used functor class and member function. With ROOT 6, these names can be omitted.See also commit 4e4cdfb from 2015, where these constructors were introduced.
The idea is to clear a bit more the jungle of
TH1constructors, of which there are too many. That makes it confusing for our uses and for cppyy overload resolution.